fix: create tpw table if doesn't exist #229
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.gitattributes
Outdated
| @@ -0,0 +1,4 @@ | |||
| /.yarn/** linguist-vendored | |||
There was a problem hiding this comment.
why check these in? shouldn't we just git ignore .yarn?
There was a problem hiding this comment.
that's the file generated by yarn init. I think it's safe to keep it as is
There was a problem hiding this comment.
yarn modern is super opinionated about determinism in a way that I'm not sure aligns with our needs here. I'd much prefer to not check in .yarn/ and rely on yarn.lock being sufficient
bin/junk.js
Outdated
| @@ -0,0 +1,62 @@ | |||
| const {BigQuery} = require('@google-cloud/bigquery') | |||
There was a problem hiding this comment.
is this junk.js needed? rename or delete?
There was a problem hiding this comment.
oups, sorry, just forgot to remove my test script :)
| @@ -9,3 +9,6 @@ gcp-credentials.json | |||
| *-subset.js | |||
| *-subset.d.ts | |||
| *.generated.sql | |||
|
|
|||
|
|
|||
| .yarn | |||
|
🎉 This PR is included in version 0.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This MR fixes broken pipeline when destination temporary table (
third_party_web) doesn't exist. Script will check if exists then create with a schema if it doesn't. Fix #227It also bumps to bigquery latest (v7.9.0) to fix an issue when we target a dataset in a different project than the one locally configured.
It also move project to yarn v4 and nodejs v22 to fix an issue I had installing project on my macos machine (issue with canvas dependency - used to generate chart in readme).
This MR can be split if needed.